Save BlockTransaction and BlockOperation when sync #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geod24
suggested changes
Jan 2, 2019
spikeekips
approved these changes
Jan 2, 2019
anarcher
force-pushed
the
sync-block-tx
branch
from
23ab440
to
04d32c5
Compare
@Geod24 Oh, I removed this dependency changes in comments :-> |
anarcher
force-pushed
the
sync-block-tx
branch
from
0390adc
to
8ce8881
Compare
Codecov Report
@@ Coverage Diff @@
## master #893 +/- ##
==========================================
- Coverage 60.38% 60.21% -0.18%
==========================================
Files 153 153
Lines 10724 10746 +22
==========================================
- Hits 6476 6471 -5
- Misses 3512 3532 +20
- Partials 736 743 +7
Continue to review full report at Codecov.
|
|
Ping~ |
kfangw
approved these changes
Jan 3, 2019
Charleslee522
approved these changes
Jan 3, 2019
| return | ||
| } | ||
|
|
||
| func ProcessProposerTransaction(st *storage.LevelDBBackend, blk block.Block, ptx ballot.ProposerTransaction, log logging.Logger) (err error) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue
Background
This PR intent that when syncer finishes a block, the operations and the transactions of this block are saved with finishing the block in sync/watcher node.
Solution
when syncer finishes a block, the operations and the transactions of this block are saved with finishing the block in sync/watcher node.
Possible Drawbacks
Without
SavingBlockOperations, It makes slower sync/watcher time than withSavingBlockOperations.