Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle when an activity type does not exist #6

Closed
ggreg opened this issue Jul 14, 2014 · 3 comments
Closed

Handle when an activity type does not exist #6

ggreg opened this issue Jul 14, 2014 · 3 comments
Assignees

Comments

@ggreg
Copy link
Contributor

ggreg commented Jul 14, 2014

In this case, the executor has to create the activity type and let the replay behavior try to schedule the activity again.

This allows to remove the .get_or_create() calls from ActivityTask.schedule() and to only query SWF when needed. It also permit to run all the tests without AWS API keys.

@ggreg
Copy link
Contributor Author

ggreg commented Aug 4, 2014

It should be handled as a case of #5 when the activity could not be scheduled because the activity type is not registered i.e. does not exist.

ggreg pushed a commit that referenced this issue Aug 5, 2014
@ggreg
Copy link
Contributor Author

ggreg commented Aug 5, 2014

There is still an issue with simple-workflow that connects to the SWF API whenever it instanciates a model.

@ggreg
Copy link
Contributor Author

ggreg commented Aug 5, 2014

The rationale for this issue is:

  1. Avoid to call .get_or_create() when scheduling a task because it always at least involves one call to the SWF API and add a significant latency if many tasks are scheduled.
  2. Do not require AWS credentials to launch the tests.

1. is solved. But not 2.. We could solve 2. by mocking the connection to AWS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant