Skip to content
This repository has been archived by the owner on Mar 5, 2023. It is now read-only.

all: implement return action and execTemplate func #6

Merged
merged 2 commits into from
Apr 9, 2022

Conversation

jo3-l
Copy link
Contributor

@jo3-l jo3-l commented Apr 16, 2021

Note
You may want to only look at this commit during review as the rest is just noise from having the commits from havin #4 in here too.

Description
This implements execTemplate and return. return stops execution of the current template and returns the result to the caller. The return value can be retrieved through calling the execTemplate function.

Status
All tests pass, except the newline ones mentioned earlier.

@jo3-l jo3-l force-pushed the feat/return-and-exec-template branch 3 times, most recently from e04fa80 to 9e7c721 Compare April 16, 2021 22:26
@jo3-l jo3-l marked this pull request as draft April 16, 2021 23:34
@jo3-l jo3-l force-pushed the feat/return-and-exec-template branch 3 times, most recently from 4b3ec6e to 9df0f58 Compare April 17, 2021 01:38
@jo3-l jo3-l marked this pull request as ready for review April 17, 2021 01:42
@jo3-l jo3-l force-pushed the feat/return-and-exec-template branch from 9df0f58 to 2d2878c Compare April 17, 2021 03:51
@jo3-l jo3-l force-pushed the feat/return-and-exec-template branch from 2d2878c to bd10da9 Compare April 24, 2021 17:03
@jo3-l jo3-l force-pushed the feat/return-and-exec-template branch 2 times, most recently from c12c31f to 8042821 Compare May 1, 2021 23:44
@jo3-l jo3-l force-pushed the feat/return-and-exec-template branch from 8042821 to e253718 Compare May 25, 2021 15:46
@jo3-l
Copy link
Contributor Author

jo3-l commented Jun 6, 2021

Re-drafting this for now. See #4 (comment).

@jo3-l jo3-l marked this pull request as draft June 6, 2021 21:28
@jo3-l jo3-l force-pushed the feat/return-and-exec-template branch 2 times, most recently from 197a74f to e7aaf7c Compare June 7, 2021 05:54
@jo3-l jo3-l marked this pull request as ready for review June 7, 2021 05:59
@jo3-l jo3-l force-pushed the feat/return-and-exec-template branch 2 times, most recently from 2e23d43 to b9730bd Compare June 12, 2021 18:58
@jo3-l jo3-l force-pushed the feat/return-and-exec-template branch from b9730bd to 3d483dc Compare June 14, 2021 18:05
@ashishjh-bst
Copy link
Contributor

Has conflicts after the try catch and while features have been merged @jo3-l

@jo3-l jo3-l force-pushed the feat/return-and-exec-template branch from 3d483dc to afabd8d Compare April 3, 2022 17:46
@jo3-l
Copy link
Contributor Author

jo3-l commented Apr 3, 2022

Rebased.

@ashishjh-bst ashishjh-bst merged commit 5a8f9bb into botlabs-gg:master Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants