Fix double invocation of progress callbacks #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -362,6 +388,7 @@ def _upload_parts(self, upload_id, filename, bucket, key, callback, | |||
| num_parts = int( | |||
| math.ceil(self._os.get_file_size(filename) / float(part_size))) | |||
| max_workers = self._config.max_concurrency | |||
| max_workers = 1 | |||
There was a problem hiding this comment.
Sorry about that, will remove.
|
Looks good to me. I had a comment though about a line that looks like should have been deleted. 🚢 |
Fixes boto#98. This works by registering two handlers to disable/re-enable callbacks during the request-created event handling. So for signature version 4, you now have:: * request-created: - disable_callbacks() (via register_first()) - client._sign_request() (via register()) - enable_callbacks() (via register_last()) Added an integration test for this because the crux of this working is because of the coordination of the event system with the disabling/enabling of callbacks. This will require a corresponding fix in botocore as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98.
This works by registering two handlers to disable/re-enable
callbacks during the request-created event handling. So
for signature version 4, you now have::
Added an integration test for this because the crux of this
working is because of the coordination of the event system
with the disabling/enabling of callbacks.
This will require a corresponding fix in botocore as well. (boto/botocore#560)
cc @kyleknap @mtdowling