Fix filter method from clobering identifier params #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This especially affects ec2 operations where the identifier is injected into the Filters param. So if the Filters param was specified in the filter() method, the identifier part in the Filters param would get clobbered.
|
|
||
| self.parent.id = 'my-id' | ||
| list(collection.filter( | ||
| Filters=[{'Name': 'another-filter', 'Values': ['foo']}])) |
There was a problem hiding this comment.
wait, nevermind, I see, this is an indent from the second paren.
|
|
Looks good once the botocore PR gets merged.
kyleknap
added a commit
that referenced
this pull request
Jun 29, 2015
Fix filter method from clobering identifier params
This was referenced Aug 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This especially affects ec2 operations where the identifier is injected into the
Filtersparam. So if theFiltersparam was specified in thefilter()method, the identifier part in theFiltersparam would get clobbered.Fixes: #148
Note the tests will not pass till this PR is merged: boto/botocore#592
cc @jamesls @mtdowling