Adapt to botocore pr 645 #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, forget the 3rd commit. |
rayluo
force-pushed
the
adapt-to-botocore-pr-645
branch
from
1be9673
to
226e4eb
Compare
| @@ -19,6 +19,12 @@ | |||
| from boto3.docs.service import ServiceDocumenter | |||
|
|
|||
|
|
|||
| # This is a temporary hack | |||
| def _snake2camel(s): | |||
There was a problem hiding this comment.
What was the reason for adding this as opposed to what I did in my pending PR? I know you labeled it as temporary, but it seems super fragile.
rayluo
force-pushed
the
adapt-to-botocore-pr-645
branch
from
226e4eb
to
a316107
Compare
rayluo
force-pushed
the
adapt-to-botocore-pr-645
branch
from
a316107
to
b97c76d
Compare
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a quick patch to work with boto/botocore#645
All the commits here are duplicated in pending PR #239