Returned future result in S3Transfer's download and upload #3316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
return
statement to S3Transfer's methodsupload_file()
anddownload_file()
.copy()
,upload_fileobj()
, anddownload_fileobj()
insides3/inject.py
. These functions return the value for their future objects.Rationale
upload_file()
andupload_fileobj()
on a bucket object. For example, before the changes in this PR, in this case:resp
wasNone
. This is in contrast toput_object()
, which does return upload metadata.Caveats
s3transfer
, namely this PR: Returned ETag for uploaded entities s3transfer#244. However, these two PRs can be independently merged and are not necessarily related. One might want to merge this PR even indepenently for the sake of ensuring consistent return behavior withcopy()
,upload_fileobj()
, anddownload_fileobj()
insideinject.py
.