Change XML name of tags to match EC2 documentation #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the AWS documentation that I referred to: http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ApiReference-query-CreateTags.html |
|
This should be fixed now in the 0.5.0 release. |
stealthycoin
pushed a commit
to stealthycoin/botocore
that referenced
this pull request
Dec 1, 2016
# This is the 1st commit message: # This is a combination of 6 commits. # This is the 1st commit message: Add idempotency token autoinjection. # The commit message boto#2 will be skipped: # Remove unused imports # The commit message boto#3 will be skipped: # First draft of injecting idempotencyToken # The commit message boto#4 will be skipped: # Register with the before-parameter-build event everywhere. # The commit message boto#5 will be skipped: # Test injecting indepotency token and not replacing an existing one. # The commit message boto#6 will be skipped: # Not sure how I managed to modify this. # The commit message boto#7 will be skipped: # PEP8 # The commit message boto#8 will be skipped: # PEP8 # The commit message boto#9 will be skipped: # Ignore mock models from tests that do not care about the model. # The commit message boto#10 will be skipped: # Remove test for members which will always be on input_shape # The commit message boto#1 will be skipped: # Rewrite functional test as two functional tests # The commit message boto#2 will be skipped: # Make the idempotency callback less specific/lower priority # The commit message boto#3 will be skipped: # Change tests so the assert happens in the test fns instead of setup # The commit message boto#4 will be skipped: # Fix tests to use MagicMock which handles iteration properly. # The commit message boto#5 will be skipped: # Add better logger message # The commit message boto#6 will be skipped: # Add a unit test for idempotent token injection # The commit message boto#2 will be skipped: # Move idempotency check to the operation model # The commit message boto#3 will be skipped: # Fix unit test to mock the new get_idempotent_members # The commit message boto#4 will be skipped: # Change name and get rid of redundant property # The commit message boto#5 will be skipped: # Added idempotency to the metadata # The commit message boto#6 will be skipped: # Added test for a pre-provided idempotency key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the XML name of tags to
TagfromItem.I'm using botocore through aws-cli and found that CreateTags didn't work. It set the tag URL parameter to be Item.1.Key rather than Tag.1.Key as it should be.