Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist docutils 0.15 #1788

Merged
merged 3 commits into from
Jul 21, 2019
Merged

Blacklist docutils 0.15 #1788

merged 3 commits into from
Jul 21, 2019

Conversation

dstufft
Copy link
Contributor

@dstufft dstufft commented Jul 21, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 21, 2019

Codecov Report

Merging #1788 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1788   +/-   ##
========================================
  Coverage    92.46%   92.46%           
========================================
  Files           53       53           
  Lines         9852     9852           
========================================
  Hits          9110     9110           
  Misses         742      742

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5b5aff...68fc74c. Read the comment docs.

@dstufft dstufft merged commit dabf098 into boto:develop Jul 21, 2019
@asottile
Copy link

given upstream fixed this, should this be reverted now?

@joguSD
Copy link
Contributor

joguSD commented Jul 23, 2019

@asottile We intend to keep an upper bound going forward, all of our dependencies should have one and docutils was a bit of a miss since it releases so infrequently. We're going to do a little verification but I don't suspect there's much holding us back from bumping this to <0.16.

@asottile
Copy link

here's hoping that doesn't take 3 months <3

@glaubitz
Copy link

I'm packaging botocore and boto3 for openSUSE/SLE and we're therefore using the docutils version available in the various openSUSE distributions which will certainly be >= 0.15 for the openSUSE Factory distribution. We cannot pick arbitrary versions as the docutils package is shared with other python packages.

Thus, I was wondering what the reason is that newer versions of docutils are supposed to be blacklisted? Is there any incompatibility we need to be aware of

CC @rjschwei

@asottile
Copy link

I'm packaging botocore and boto3 for openSUSE/SLE and we're therefore using the docutils version available in the various openSUSE distributions which will certainly be >= 0.15 for the openSUSE Factory distribution. We cannot pick arbitrary versions as the docutils package is shared with other python packages.

Thus, I was wondering what the reason is that newer versions of docutils are supposed to be blacklisted? Is there any incompatibility we need to be aware of

CC @rjschwei

docutils 0.15 temporarily shipped a syntax error in python 2, it has since been corrected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants