Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept proxy config via environment variables #2595

Closed
wants to merge 1 commit into from

Conversation

mogul
Copy link

@mogul mogul commented Jan 19, 2022

Makes these proxy settings easily configurable via environment variables.

See aws/aws-cli#9045 for context.

Makes these settings easily configurable via environment variables.
@tim-finnigan
Copy link
Contributor

Thanks @mogul for the PR. One issue with this PR is that those variable names are specific to S3. They would have to be generalized as they could apply to other services. Another thing is that we would need to collaborate with other SDKs if we're considering 'AWS_*' prefixed variable names. But first we want to get more community feedback on the issue you created. I’m going to set this PR to Draft but we can keep your issue open for tracking the request.

@tim-finnigan tim-finnigan marked this pull request as draft May 3, 2022 18:27
@tim-finnigan
Copy link
Contributor

Thanks for your patience, as mentioned earlier the work involving environment variables would require coordination across SDK teams. We're continuing to track aws/aws-cli#9045 for consideration but as of now there are still no plans for this. Going to close this PR as not planned at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants