Add generic support for client context params #3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlm6693
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3037 +/- ##
===========================================
+ Coverage 93.44% 93.46% +0.01%
===========================================
Files 66 66
Lines 13965 14007 +42
===========================================
+ Hits 13049 13091 +42
Misses 916 916
☔ View full report in Codecov by Sentry. |
nateprewitt
reviewed
Oct 12, 2023
nateprewitt
reviewed
Oct 12, 2023
nateprewitt
reviewed
Oct 20, 2023
nateprewitt
reviewed
Oct 24, 2023
nateprewitt
approved these changes
Oct 24, 2023
aws-sdk-python-automation
added a commit
that referenced
this pull request
Oct 25, 2023
* release-1.31.71: Bumping version to 1.31.71 Update to latest models Add generic support for client context params (#3037)
4 tasks
dlm6693
added a commit
to dlm6693/botocore
that referenced
this pull request
Nov 7, 2023
* add `client_context_params` config setting * add `client_context_params` to docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds client context parameters generically across all AWS services and adds them to docs. This PR can be reviewed in two parts. Should be merged in tandem with boto/boto3#3894.
Commit 1
Adds
client_context_paramsconfig option. If the service is s3 or s3control, still use the s3 config param over client context params if it is set. Params are modeled as capital case but are expected in snake case by the endpoint resolver. This commit also includes some code cleanup for the existing client context params test.Commit 2
Adds client context params docs to each service client's homepage if any are modeled. Existing s3/s3control params are excluded because overlapping behavior already exists in the s3 config. There are no other modeled client context params today, but when one is added to a service model, the new docs section will look something like this: