Fix regression for supported timestamp formats #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now accept: * datetime objects * ISO8601 * epoch seconds (both as an int or a string) anytime a timestamp type is needed. This puts back the previous behavior that botocore had. To accomodate this, I've added a new date parsing utility method in the utils module. It accepts any of the types listed above and returns a datetime object with tzinfo. This makes it easy to write protocol specific timestamp serializers as they now can assume they'll always be working with a datetime object with time zone info.
|
This looks good. 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now accept:
anytime a timestamp type is needed. This puts back the previous
behavior that botocore had.
To accomodate this, I've added a new date parsing utility method
in the utils module. It accepts any of the types listed above and
returns a datetime object with tzinfo. This makes it easy to write
protocol specific timestamp serializers as they now can assume
they'll always be working with a datetime object with time zone info.
cc @kyleknap @danielgtaylor