Cloudfront waiters #426
Merged
Cloudfront waiters #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were using the wrong JMESPath expression to check the status of the AWS resource.
| self.loader = Loader(self.data_path) | ||
|
|
||
| # Make sure the cache is clear. | ||
| self.loader._cache.clear() |
There was a problem hiding this comment.
Were you seeing cache issues before you added this? Line 522 we're not passing in a cache to the loader so it should be recreating a brand new cache each test.
There was a problem hiding this comment.
No, it is there by mistake. I was just copying some lines from another test that I found that uses loaders. This line is not needed.
|
|
Small question about clearing the cache, otherwise looks good.
|
I removed the unnecessary clearing of the cache in the test. Merging. Will update CLI changelog as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: aws/aws-cli#1059
There were two changes made in this PR:
Make the JMESPath success path for the waiter take into account the outer element in the cloudfront response. Without the outer element included, you get a bunch of max retries exceeded because the JMESPath query is not using the correct path to search for the success state.
Doubled the max retry attempts. I tested it for a single object invalidation, and with the current configuration, the max retries were consistently reached. I was estimating it took around 15 minutes to complete the invalidation, but the current configuration would wind up waiting for 10 minutes. By doubling the retry attempts, it bumped this to 20 minutes.
cc @jamesls @danielgtaylor