Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy_snapshot handler to work with clients #498

Merged
merged 1 commit into from
Mar 24, 2015

Conversation

jamesls
Copy link
Member

@jamesls jamesls commented Mar 24, 2015

This handler still relied on operation objects, which no
longer works with the client switchover.

As part of this change, I switched over the test_ec2 integ
tests over to clients.

cc @kyleknap @danielgtaylor

This handler still relied on operation objects, which no
longer works with the client switchover.

As part of this change, I switched over the test_ec2 integ
tests over to clients.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 94.63% when pulling 1dc2872 on jamesls:fix-copy-snapshot-client into 82835a0 on boto:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 94.63% when pulling 1dc2872 on jamesls:fix-copy-snapshot-client into 82835a0 on boto:develop.

@kyleknap
Copy link
Contributor

It looks good to me. I actually was working on porting the ec2 tests to clients. Your code looks similar to what I was working on. I also ran into the CopySnapshot issue where an endpoint was needed, but I had not figured out a great solution for it. I do not think there is a good solution such that we do not rely on endpoint till we have the presigner class. Otherwise, 🚢

@jamesls jamesls merged commit 1dc2872 into boto:develop Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants