Add machinelearning wait commands #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DataSourceAvailable: Wait until JMESPath query Results[].Status returns COMPLETED for all elements when polling with describe-data-sources. * MLModelAvailable: Wait until JMESPath query Results[].Status returns COMPLETED for all elements when polling with describe-ml-models. * EvaluationAvailable: Wait until JMESPath query Results[].Status returns COMPLETED for all elements when polling with describe-evaluations. * BatchPredictionAvailable: Wait until JMESPath query Results[].Status returns COMPLETED for all elements when polling with describe-batch-predictions.
|
Awesome, thanks! |
1 similar comment
jamesls
added
the
enhancement
| { | ||
| "expected": "FAILED", | ||
| "matcher": "pathAny", | ||
| "state": "success", |
There was a problem hiding this comment.
I think this should be state: failure
|
Looks good, just had the same feedback as the route53 changes. We can remove implicit retries, and the error states should be failures. I don't mind updating the code to remove these. |
|
@jamesls I am fine with you updating the code. |
|
Cool, merged. Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
machinelearnig's create operations are basically asynchronous but there's no wait commands, so I've added following wait commands.
Wait until JMESPath query Results[].Status returns COMPLETED for all elements when polling with describe-data-sources.
Useful for
aws machinelearning create-data-source-from-s3operation.Wait until JMESPath query Results[].Status returns COMPLETED for all elements when polling with describe-ml-models.
Useful for
aws machinelearning create-ml-modeloperation.Wait until JMESPath query Results[].Status returns COMPLETED for all elements when polling with describe-evaluations.
Useful for
aws machinelearning create-evaluationoperation.Wait until JMESPath query Results[].Status returns COMPLETED for all elements when polling with describe-batch-predictions.
Useful for
aws machinelearning create-batch-predictionoperation.Feedback is welcome.