Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some moderate refactoring for boto3 docstrings #642

Merged
merged 1 commit into from
Sep 11, 2015

Conversation

kyleknap
Copy link
Contributor

@kyleknap kyleknap commented Sep 3, 2015

Includes extracting out the logic that creates the client classes into a public function. This is needed because resource factories in boto3 do not have access to the client's class, and thus its name, when creating the resource class.

There was also some moving around some of the internals of the docstring class to make it easier to inherit from for example:

class ActionDocstring(LazyLoadedDocstring):
    def __init__(self, *args, **kwargs):
        super(ActionDocstring, self).__init__(*args, **kwargs)
        self._docstring_writer = document_action

cc @jamesls @mtdowling @rayluo

Includes extracting out the logic that creates the client classes into
a public function and moving around some of the internals of the docstring
class to make it easier to inherit from.
@mtdowling
Copy link
Contributor

🚢

This was referenced Sep 3, 2015
@rayluo
Copy link
Contributor

rayluo commented Sep 8, 2015

🚢

@rayluo rayluo added the enhancement This issue requests an improvement to a current feature. label Sep 10, 2015
kyleknap added a commit that referenced this pull request Sep 11, 2015
Some moderate refactoring for boto3 docstrings
@kyleknap kyleknap merged commit c4b851d into boto:develop Sep 11, 2015
@kyleknap kyleknap deleted the boto3-docstring branch September 11, 2015 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue requests an improvement to a current feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants