Don't use MD5 with s3v4 #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -150,7 +150,7 @@ def _calculate_md5_from_file(fileobj): | |||
| def conditionally_calculate_md5(params, **kwargs): | |||
| """Only add a Content-MD5 when not using sigv4""" | |||
| signer = kwargs['request_signer'] | |||
| if signer.signature_version != 'v4': | |||
| if signer.signature_version != 'v4' and signer.signature_version != 's3v4': | |||
There was a problem hiding this comment.
What about if signer.signature_version not in ['v4, 's3v4']?
|
|
JordonPhillips
force-pushed
the
s3-md5
branch
from
b9ea283
to
7a31dd7
Compare
|
🚢 |
JordonPhillips
added a commit
that referenced
this pull request
Feb 24, 2016
Don't use MD5 with s3v4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a function which avoids md5 when in sigv4, but forgot to include s3v4 even though we attach the function to several s3 commands.
cc @jamesls @kyleknap @rayluo