Add support for Tagging and TaggingDirective #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For multipart copies, the TaggingDirective needs to be filtered out. Also added tests to make sure it gets filtered out.
kyleknap
changed the title
Tagging and TaggingDirective
This was referenced Jan 15, 2020
stealthycoin
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just allows users to proxy the values through to the
uploadandcopymethods. Currently,Taggingis modeled as a string that you have to urlencode yourself. I did not add any special logic to do the url encoding on the user's behalf. However, in the future we can always allowTaggingto accept a dictionary and have eithers3transferorbotocoreurlencode it on your behalf.