Fix hang on shutdown with multiple threadpools #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue that occurs when a download completion is expected after the threadpools have shutdown.
Here is a test that reproduces the problem. Without the patch, running this hangs forever, demonstrating the bug. With the patch,
pytest
terminates as soon as theKeyboardInterrupt
is thrown, as expected. This test is not appropriate to include in the test suite, since it halts the whole test runner on success and hangs on failure.(Any error lesser than
KeyboardInterrupt
fails to demonstrate the bug underpytest
.pytest
catches the error and prevents the global shutdown hook from triggering until the tests are cleaned up)This patch is licensed Apache 2.0, in accordance with the boto/s3transfer contribution policy.