fix(lock): delete redis subservice lock if the refresh or release fai…

…led (#617)
botpress · Aug 31, 2023 · 78f978a · 78f978a
1 parent 15546ec
commit 78f978a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/engine/src/distributed/redis/subservice.ts b/packages/engine/src/distributed/redis/subservice.ts
@@ -167,6 +167,7 @@ export class RedisSubservice implements DistributedSubservice {
         void this.refresh(ressource)
       }, DEFAULT_LOCK_TTL / 6)
     } catch (e) {
+      delete this.locks[ressource]
       this.logger.error(e, `Failed to extend lock ${ressource}`)
     }
   }
@@ -176,7 +177,10 @@ export class RedisSubservice implements DistributedSubservice {
       clearTimeout(lock.timeout)
     }
 
-    await this.redlock.release(lock.lock)
+    await this.redlock.release(lock.lock).catch((e: Error) => {
+      this.logger.error(e, `Failed to release lock ${lock.ressource}`)
+    })
+
     delete this.locks[lock.ressource]
   }