-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(channels): delete channels #271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-2125 Messaging make a channels package
Putting all channels in a single package will allow use to write v2 versions more easily, as well as decoupling the channel code from the server code, and reducing considerably the amount of code in the server package |
laurentlp
approved these changes
Dec 9, 2021
* use telegram from channel package * use package twilio * use teams * use smooch * example change * config change * slack * messenger * vonage * integrate other channels * telegram + * fix tests * fix docker * initialize * stop when server closes * dispatch stop * webhookRouter * ChannelTemplate * prettier * fix
samuelmasse
added a commit
that referenced
this pull request
Dec 10, 2021
* feat(channels): conversation.started * fix * feat(channels): channels package * fix * config file * schwag * more schwag * twilio * twilio validation * smooch * change config * abstract * abstract telegram * abstract twilio * abstract app * fix * teams * fix * bring changes * bring changes * bring changes * add base renderers * refact streams * telegram all content types * abstract * twilio all content types * slack all content types * vonage all content types * messenger all content * teams all content * smooch all content * destroy * initialize * bring changes * chore(channels): delete channels (#271) * delete channel code * chore(channels): use channels from channels package (#272) * use telegram from channel package * use package twilio * use teams * use smooch * example change * config change * slack * messenger * vonage * integrate other channels * telegram + * fix tests * fix docker * initialize * stop when server closes * dispatch stop * webhookRouter * ChannelTemplate * prettier * fix * any -> void * remove || '*' in server * remove ChannelStreamRenderers * initialize messenger * messenger map scope * fix * put back twilio testing * vonage receive content types * restore index responses * fix * fix * logger * logger * printWebhook * kvs interface * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes channels to use those in the channels package
Closes DEV-2125