chore(channels): use channels from channels package #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-2125 Messaging make a channels package
Putting all channels in a single package will allow use to write v2 versions more easily, as well as decoupling the channel code from the server code, and reducing considerably the amount of code in the server package |
samuelmasse
commented
Dec 9, 2021
Comment on lines
-85
to
-93
| this.cache = await this.cachingService.newServerCache('cache_instance_by_conduit_id', { | ||
| dispose: async (k, v) => { | ||
| if (!this.destroyed) { | ||
| await this.handleCacheDispose(k, v) | ||
| } | ||
| }, | ||
| max: 50000, | ||
| maxAge: ms('30min') | ||
| }) |
There was a problem hiding this comment.
We'll need to put back this logic of clearing channels after not being used for x amount of minutes. To be done in future PR.
samuelmasse
commented
Dec 9, 2021
Comment on lines
48
to
+53
| private async onConduitDeleting(conduitId: uuid) { | ||
| this.cache.del(conduitId, true) | ||
| await this.instances.stop(conduitId) | ||
| } | ||
|
|
||
| private async onConduitUpdated(conduitId: uuid) { | ||
| this.cache.del(conduitId, true) | ||
| await this.instances.stop(conduitId) |
There was a problem hiding this comment.
Notice here we were doing distributed invalidations on the cache. Now there is a dispatcher in the instance service that informs the other node when they need to stop their conduit
laurentlp
reviewed
Dec 9, 2021
| @@ -27,6 +27,7 @@ | |||
| "dependencies": { | |||
| "@botpress/messaging-base": "0.0.1", | |||
| "@botpress/messaging-engine": "0.0.1", | |||
| "@botpress/messaging-channels": "0.0.1", | |||
There was a problem hiding this comment.
We should consider using '*' as the version since it references another package and we want to use it whatever version it is at
| }) | ||
| this.cache.set(conduitId, instance, channel.lazy && this.lazyLoadingEnabled ? undefined : Infinity) | ||
|
|
||
| await this.emitter.emit(InstanceEvents.Setup, conduitId) |
There was a problem hiding this comment.
It would make more sense IMHO if we were to send events with the same name as the function that triggers them! So in this case, shouldn't we use Start instead of setup? Or maybe we should rename the function to setup instead of start? What do you think?
samuelmasse
commented
Dec 9, 2021
Comment on lines
79
to
82
| private useWebhook() { | ||
| // TODO: remove this dependency on server env vars | ||
| return !yn(process.env.SPINNED) || yn(process.env.CLUSTER_ENABLED) | ||
| } |
samuelmasse
added a commit
that referenced
this pull request
Dec 9, 2021
* delete channel code * chore(channels): use channels from channels package (#272) * use telegram from channel package * use package twilio * use teams * use smooch * example change * config change * slack * messenger * vonage * integrate other channels * telegram + * fix tests * fix docker * initialize * stop when server closes * dispatch stop * webhookRouter * ChannelTemplate * prettier * fix
samuelmasse
added a commit
that referenced
this pull request
Dec 10, 2021
* feat(channels): conversation.started * fix * feat(channels): channels package * fix * config file * schwag * more schwag * twilio * twilio validation * smooch * change config * abstract * abstract telegram * abstract twilio * abstract app * fix * teams * fix * bring changes * bring changes * bring changes * add base renderers * refact streams * telegram all content types * abstract * twilio all content types * slack all content types * vonage all content types * messenger all content * teams all content * smooch all content * destroy * initialize * bring changes * chore(channels): delete channels (#271) * delete channel code * chore(channels): use channels from channels package (#272) * use telegram from channel package * use package twilio * use teams * use smooch * example change * config change * slack * messenger * vonage * integrate other channels * telegram + * fix tests * fix docker * initialize * stop when server closes * dispatch stop * webhookRouter * ChannelTemplate * prettier * fix * any -> void * remove || '*' in server * remove ChannelStreamRenderers * initialize messenger * messenger map scope * fix * put back twilio testing * vonage receive content types * restore index responses * fix * fix * logger * logger * printWebhook * kvs interface * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports channels from the @botpress/messaging-channels packages and uses them as replacement for the old channel code that was inside the server code.
Closes DEV-2125