Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] File view in code editor tab does not change when selecting file of same name (global / local) #1293

Open
dvncan opened this issue Mar 23, 2021 · 2 comments · Fixed by botpress/botpress#5646
Labels
bug Something isn't working

Comments

@dvncan
Copy link

dvncan commented Mar 23, 2021

Describe the bug
The code editor's file view does not change when toggling between a local & global file of the same name. The bug causes confusion when copying a global file to a local bot or vise versa. As the tab which has the file name does not denote if it is a global or local file, you must close the tab and be sure to open the correct file before editing.

To Reproduce

  1. Open a bot in Botpress Studios
  2. Navigate to the code editor
  3. Copy or find a file that is replicated globally and locally
  4. With your mouse click to open one of the files and click between both files
  5. The view will stay the same, although the selected file changes
  6. This is very noticable when you have built a custom action from a global file and the view does not show it, or you have had the wrong copy of the file open and you are editing the global version while the local remains the same.

Expected behavior
Either two tabs open, one for each copy of the file. A denotation will have to accompany the file title.
or
The file tab toggles between the two files being selected, and the title of the tab does not change.

Screenshots
Local file (clicking both)
Screen Shot 2021-03-23 at 10 42 27 AM
Screen Shot 2021-03-23 at 10 42 12 AM

Global file (clicking both)
Screen Shot 2021-03-23 at 10 43 16 AM
Screen Shot 2021-03-23 at 10 42 48 AM

Environment (please complete the following information):

Demo deployment

  • OS: macOS
  • Browser Chrome
  • Botpress Version 12.19.2
  • Node version 12.20.2
@dvncan dvncan added the bug Something isn't working label Mar 23, 2021
@Michael-N-M
Copy link

With the new tab support in code editor, maybe opening it in a seperate tab then appending the file paths to the title to differentiate them.

@dvncan
Copy link
Author

dvncan commented Mar 26, 2021

that would work, something like "global/hitlnext.json" right next to "local/hitlnext.json".. You only really need to differentiate the second tab, but right now it makes me confused as to which file I am editing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants