[BUG] Overriding a bot on a stage breaks DialogEngine and fails to update content-elements

[daukadolt]

Describe the bug
In a workspace with 3 pipeline stages when a bot on some stage is overridden (using on_request_change pipeline hook in a comment below):

1. Newly added contents are not visible in the flow editor and contents page of the bot

2. Chat stops working

May be related to this issue.

To Reproduce
Steps to reproduce the behavior:

1. Set up a pipeline with 3 stages
2. Create an empty bot

3. Add some initial content to it

4. Promote the bot to the next stage

5. Promoted bot should work for now

6. Add some new content to the original bot and promote it again

7. Open the studio for the promoted bot. You should see newly added content-elements rendered empty and webchat not working

Expected behavior
The promoted bot should have a working webchat and render newly added content-elements in the flow editor

Environment (please complete the following information):

• OS: macOS
• Browser Chrome
• Browser Version Version 96.0.4664.110 (Official Build) (x86_64)
• Botpress Version v12.26.7
• NodeJS v12.18.1

Additional context
Add any other context about the problem here.

[daukadolt]

on_stage_request hook:

const STAGE_SEPERATOR = '__'
const VERSION_SEPERATOR = ' :: v'
const STAGE_KEY = `${botId}-PipelineVersion`

const getPromoteVersionStage = () => {
  if (pipeline.length < 2) return 'NEVER'
  let stage2 = pipeline[1]
  return stage2.id
}

const getNextVersion = async () => {
  const promoteVersion = getPromoteVersionStage() === bot.pipeline_status.stage_request.id
  
  let globalKvs = bp.kvs.global()
  let storeExists = await globalKvs.exists(STAGE_KEY)
  let curVersion = storeExists ? await globalKvs.get(STAGE_KEY) : 0
  
  if (!promoteVersion) return curVersion // Updates the bot version only on the second stage and uses that version when promoted to the last stage
  
  let nextVersion = curVersion + 1
  
  await globalKvs.set(STAGE_KEY, nextVersion)
  
  return nextVersion
}

const getStageId = () => [botId, bot.pipeline_status.stage_request.id].join(STAGE_SEPERATOR)

const getStageName = async () => {
  let botName = bot.name.split(VERSION_SEPERATOR)[0]
  let nextVersion = await getNextVersion()

  return `${botName}${VERSION_SEPERATOR}${nextVersion}`
}

const handle = async () => {
  let stageId = getStageId()
  let stageName = await getStageName()

  let botConfig = await bp.bots.getBotById(stageId)

  if (botConfig) {
    await bp.bots.createBotRevision(stageId)
  }

  bot.id = stageId
  bot.name = stageName
}

handle()

[davidvitora]

Reopening the issue since the same issue can be reproduced at 12.26.10 with Postgress DB

here is a more complete on_stage_request hook

  const STAGE_SEPERATOR = '__'
  const VERSION_SEPERATOR = ' :: v'
  const botId = bot.id.split(STAGE_SEPERATOR)[0]
  const STAGE_KEY = `${botId}-PipelineVersion`
  const botLogger = bp.logger.forBot(bot.id)

  const getPromoteVersionStage = () => {
    if (pipeline.length < 2) return 'NEVER'
    let stage2 = pipeline[1]
    return stage2.id
  }

  const getNextVersion = async () => {
    const promoteVersion = getPromoteVersionStage() === bot.pipeline_status.stage_request.id

    let globalKvs = bp.kvs.global()
    let storeExists = await globalKvs.exists(STAGE_KEY)
    let curVersion = storeExists ? await globalKvs.get(STAGE_KEY) : 0

    if (!promoteVersion) return curVersion //We only promote the version on the second pipeline stage, then run with that version from there on

    let nextVersion = curVersion + 1

    await globalKvs.set(STAGE_KEY, nextVersion)

    return nextVersion
  }

  const getStageId = () => [botId, bot.pipeline_status.stage_request.id].join(STAGE_SEPERATOR)

  const getStageName = async () => {
    let botName = bot.name.split(VERSION_SEPERATOR)[0]
    let nextVersion = await getNextVersion()

    return `${botName}${VERSION_SEPERATOR}${nextVersion}`
  }

  const handler = async () => {
    /* Generate static Id based on stage */
    try {
      let stageId = getStageId()
      let stageName = await getStageName()

      /* Modify the bot definition */
      bot.id = stageId
      bot.name = stageName
    } catch (err) {
      botLogger.error(JSON.stringify(err, null, 2))
    }

    // bot.locked = true
  }

  return handler() 

[github-actions]

Available on v12.26.11