Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth_basic: decide in check function how to deal with missing creds #1414

Closed
wants to merge 1 commit into from

Conversation

karmab
Copy link

@karmab karmab commented Mar 9, 2023

No description provided.

@karmab karmab changed the title auth_basic: decide in check function how to deal with missing credent… auth_basic: decide in check function how to deal with missing creds Mar 9, 2023
@defnull
Copy link
Member

defnull commented Sep 11, 2024

That's a breaking change in a sensitive area unfortunately. An app may have a check function that always returns True, for example because there is a middleware or proxy that handles SSO logins and adds or removes an auth header with an empty password depending on the users login state. That is actually quite common. Those apps would break and allow guests to access protected endpoints.

The auth decorator is really small, if you need to change it, just copy&paste the code and use your own version.

@defnull defnull closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants