Add ServerAdapter (fix CherryPy ServerAdapter) #932
Conversation
Since CherryPy >= 9, the server part of CherryPy has been extracted and named Cheroot. Thus the old CherryPy ServerAdapter does not work for CherryPy >= 9: the import fails, and the SSL part should be different too. Cheroot can be installed (git install cheroot) without CherryPy so that we can just have a CherootServer adapter in addition to the CherryPyServer adapter for the older versions.
Add ServerAdapter for CherryPy >= 9
06180339
changed the title
Can you provide the CherootServer code here? |
If you are using this adapter, simply switch to 'cheroot' This should fix some recent and some very old issues regarding cherrypy: fix bottlepy#947 Leave explicit the maxima version supported the CherryPy (<= 9.0.0) fix bottlepy#932 Add ServerAdapter (fix CherryPy ServerAdapter) fix bottlepy#685 Update CherryPy SSL to use latest API and work on Py3 fix bottlepy#574 Allow custom bind_addr for CherryPy (backported from commit be90814) [juergh: Adjust context, drop modifications of test/travis-requirements.txt which does not exist in 0.12.] Signed-off-by: Juerg Haefliger <juergh@protonmail.com>
Since CherryPy >= 9, the server part of CherryPy has been extracted and named Cheroot. Thus the old CherryPy ServerAdapter does not work for CherryPy >= 9: The import fails, and the SSL part should be different too. Cheroot can be installed (pip install cheroot) without CherryPy so that we can have a CherootServer adapter in addition to the CherryPyServer adapter for the older versions. I have used this class (just inheriting from bottle.ServerAdapter) and it worked for SSL and non-SSL.
(Edit:) To be clear: The proposed CherootServer adapter is foremost a fix of the CherryPyServer Adapter for the latest versions of CherryPy: When I pip install cherrypy, the cheroot server is installed along with cherrypy, and the imports are working as given in the proposed Adapter (as well as the SSL part). So one could also replace the body of the CherryPyServer adapter with the body of the proposed adapter, calling this adapter either still "CherryPyServer" or "CherootServer".
(Edit 2): Cp. http://docs.cherrypy.org/en/latest/history.html