tough: Split into tough and tough_schema #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tjkirch
reviewed
Aug 12, 2019
tjkirch
approved these changes
Aug 14, 2019
Signed-off-by: iliana destroyer of worlds <iweller@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This splits out the inner
serdemodule from tough into a new top-level crate, which will allow me to write a separate TUF repository generation tool from the same underlying struct definitions.I made a number of changes to the overall shape of the crate; all the top-level role types (
Root,Timestamp, etc) and their substructs were moved into lib.rs. The confusingly-named traitMetadatawas renamed toRole, and the enumRolewas renamed toRoleType.Since we are now using
olpc_cjson, I reordered struct items and other things to match the order that they're listed in the TUF spec, and replaced uses of BTreeMap with HashMap. This also allowed me to store any extra data in the structures, which fixes #66 (although I need to add test cases to verify this).Ran Thar with these changes and was able to execute
updog updateand reboot.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.