Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate pulling new components version #182

Merged
merged 9 commits into from
Nov 20, 2022

Conversation

koplo199
Copy link
Contributor

@koplo199 koplo199 commented Nov 16, 2022

See the entire discussion in bottlesdevs/Bottles#2223

TODO before merging:

Please do not accept new PR in the meantime (like #180), as it initially requires a lot of manual processing to create the adequate new files, and it would probably drive me insane having to do it again

@koplo199
Copy link
Contributor Author

koplo199 commented Nov 16, 2022

It is possible to monitor what the first pull request of the CI would look like here

@mirkobrombin
Copy link
Member

(still reviewing, I'm busy with other projects), about the 2 forks, are you going to maintain them? :D

@koplo199
Copy link
Contributor Author

koplo199 commented Nov 19, 2022

(still reviewing, I'm busy with other projects), about the 2 forks, are you going to maintain them? :D

😅

Honestly: in the very long term, probably not.
And this is precisely why I will replace them by GitHub CLI commands in a future PR, from what I read it could be used to achieve the same result, while being officially endorsed by GitHub.

But I would like this PR to get merged first, as it will add some substantial complexity to the code I prefer to implement it in a distinct PR. Also, and I guess it's human, it will motivate me to work on it a lot more (and will spare me the obnoxious task of manually creating files/entries for every PR that get merged in the meantime) 👼

@orowith2os
Copy link
Contributor

One more thing, possibly wait for my other cleanup PRs before merging this, if it ever does get accepted.

@koplo199
Copy link
Contributor Author

One more thing, possibly wait for my other cleanup PRs before merging this, if it ever does get accepted.

I would prefer the other way around, thank you.

@orowith2os
Copy link
Contributor

One more thing, possibly wait for my other cleanup PRs before merging this, if it ever does get accepted.

I would prefer the other way around, thank you.

Merging this before my PR would make it harder to clean up, since I'd then have to update your checker to use those new, updated paths for components.

Better to have the clean PR merged first, then this, so that it Just Works more or less immediately after being merged.

@koplo199
Copy link
Contributor Author

koplo199 commented Nov 19, 2022

Merging this before my PR would make it harder to clean up, since I'd then have to update your checker to use those new, updated paths for components.

Merging the clean up before this PR would make it harder to update my checker, since I'd then have to use your new, updated paths for components.

Better to have the clean PR merged first, then this, so that it Just Works more or less immediately after being merged.

Better to have this PR merged first, then the cleanup, so that it Just Breaks more or less immediately after being merged and you'll have to fix it yourself instead of me.

@mirkobrombin
Copy link
Member

Everything looks fine and ready for merge. Just to be sure, this doesn't require Bottles side changes right?

@koplo199
Copy link
Contributor Author

koplo199 commented Nov 20, 2022

Everything looks fine and ready for merge. Just to be sure, this doesn't require Bottles side changes right?

Correct!

@mirkobrombin mirkobrombin removed the request for review from pietrodicaprio November 20, 2022 08:29
@mirkobrombin mirkobrombin merged commit fa879cd into bottlesdevs:main Nov 20, 2022
@koplo199
Copy link
Contributor Author

koplo199 commented Nov 20, 2022

Yay merged 🎉

Is the PAT already set? If it is not configured pull requests won't be created, to configure it:

From any account (could very well be a newly created burner account like @bottlesdevs-components[BOT] or something) do
(Account) Settings -> Developer settings -> Personal access tokens -> Tokens (classic) -> Generate new token (classic) -> public_repo (No expiration)

Then copy paste it into
(Repository) Settings -> Secrets -> Actions -> New repository secret -> Name = PAT

koplo199 added a commit to koplo199/components that referenced this pull request Nov 20, 2022
Merge pull request bottlesdevs#182 from koplo199/bottlesdevs-pr
This was referenced Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants