-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate pulling new components version #182
Conversation
d9396c0
to
2f70279
Compare
It is possible to monitor what the first pull request of the CI would look like here |
(still reviewing, I'm busy with other projects), about the 2 forks, are you going to maintain them? :D |
Honestly: in the very long term, probably not. But I would like this PR to get merged first, as it will add some substantial complexity to the code I prefer to implement it in a distinct PR. Also, and I guess it's human, it will motivate me to work on it a lot more (and will spare me the obnoxious task of manually creating files/entries for every PR that get merged in the meantime) 👼 |
One more thing, possibly wait for my other cleanup PRs before merging this, if it ever does get accepted. |
I would prefer the other way around, thank you. |
Merge upstream
Merging this before my PR would make it harder to clean up, since I'd then have to update your checker to use those new, updated paths for components. Better to have the clean PR merged first, then this, so that it Just Works more or less immediately after being merged. |
Merging the clean up before this PR would make it harder to update my checker, since I'd then have to use your new, updated paths for components.
Better to have this PR merged first, then the cleanup, so that it Just Breaks more or less immediately after being merged and you'll have to fix it yourself instead of me. |
Everything looks fine and ready for merge. Just to be sure, this doesn't require Bottles side changes right? |
Correct! |
Yay merged 🎉 Is the From any account (could very well be a newly created burner account like @bottlesdevs-components[BOT] or something) do Then copy paste it into |
Merge pull request bottlesdevs#182 from koplo199/bottlesdevs-pr
See the entire discussion in bottlesdevs/Bottles#2223
TODO before merging:
Fork koplo199/actions-download-asset in the bottlesdevs organization. It is the action used to find and pull new stable versions. Forking is mandatory as upstream is not vastly used, contains multiple bugs, outdated dependencies, and is lacking required features.Replaced by GitHub CLIFork koplo199/action-gh-release in the bottlesdevs organization. It is the action used to upload archives when required. Forking is strongly advised as upstream has outdated dependencies and its maintainer hasn't been active since april. However in its current state it is functional and is vastly used, so forking is not mandatory. In fact, if action-gh-release/pull/275 was merged, there would be no reason to fork it anymore.Merged upstream!Add
PAT
as actions secret (see [Poll]: Experimental versions of dxvk, vkd3d Bottles#2223 (comment))Please do not accept new PR in the meantime (like #180), as it initially requires a lot of manual processing to create the adequate new files, and it would probably drive me insane having to do it again