Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix boolean parsing #10

Merged
merged 2 commits into from
Jan 18, 2019
Merged

Fix boolean parsing #10

merged 2 commits into from
Jan 18, 2019

Conversation

woolfred
Copy link
Contributor

Hey there!
While playing around with the library I stumbled over the bug, that all my false boolean values were parsed as true. So I added tests to recreate the problem and fixed it.

Cheers!

@woolfred
Add boolean parsing tests
b49292c 
- recreates problem of parsing 'false' boolean values as 'true'
@woolfred
Fix parsing 'false' boolean values correctly
0b21079
@coveralls
Copy link

coveralls commented Jan 14, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 67

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.013%
Totals Coverage Status
Change from base Build 66: 0.0%
Covered Lines: 134
Relevant Lines: 154
💛 - Coveralls

boudra
boudra approved these changes Jan 18, 2019
View reviewed changes
Copy link
Owner

@boudra boudra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks for the fix! 🚀

@boudra boudra merged commit 82990b5 into boudra:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boudra boudra boudra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woolfred @coveralls @boudra