support n-ary metric initialization from application environment at startup #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Thanks! Please add tests for both cases and I will merge. |
|
finally got around to implement a test. actually caught a bug, since I had not expected binaries as valid metric names. it is covered now. |
|
Sorry for the hoops, please squash this PR into one commit. |
|
it is you repos history, after all ;) done. |
joewilliams
added a commit
that referenced
this pull request
Aug 27, 2012
support n-ary metric initialization from application environment at startup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like being able to initialize a histogram of the nice new
slide_uniform from my application environment on startup like:
[{folsom, [{histogram, [{my_app, my_histo}, slide_uniform, {60, 1028}]
}]}]
The patch makes this possible as well as remaining backward compatible
with old name-only scheme.