Tests for collect and squashoutput #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Time consuming to test all 9 compression levels netCDF supports, and does not test our code.
Create dump file parameters as dicts, and then iterate over them calling create_dump_file().
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
===========================================
+ Coverage 10.33% 24.94% +14.61%
===========================================
Files 16 16
Lines 2312 2385 +73
Branches 472 497 +25
===========================================
+ Hits 239 595 +356
+ Misses 2063 1708 -355
- Partials 10 82 +72
Continue to review full report at Codecov.
|
|
One downside is that the tests are a bit slow (CI takes ~20mins), but I think that's inevitable when reading/writing to/from disk - I think it's more important to test as many arguments to |
Better practice, as assert statements are intended for tests.
|
What an awesome piece of work @johnomotani 🥳 |
loeiten
reviewed
May 11, 2021
Co-authored-by: Michael Løiten <michael.l.magnussen@gmail.com>
|
Thanks @loeiten! I think I've addressed all your comments now. |
Makes test data creation more compact and easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for
collect()andsquashoutput()to the test suite. The tests cover core, SOL, single-null, connected double-null and disconnected double-null topologies (the last two aren't really different becausecollect()doesn't need the separatrix positionsixseps1andixseps2, but is included for completeness - limiter topology is missing, but is not really different from core or SOL for the same reason). Thexguards,yguards,tind,xind,yindandzindarguments are all tested, as are thecompressionandcomplevelarguments tosquashoutput(which verify that we get identical data when using compression). Edit: now added tests for differentMXGandMYGvalues for one case.If anyone can see anything significant missing, please add it!