Fix animate_list blank figures #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=========================================
+ Coverage 47.05% 47.5% +0.44%
=========================================
Files 11 11
Lines 1052 1061 +9
Branches 210 212 +2
=========================================
+ Hits 495 504 +9
Misses 496 496
Partials 61 61
Continue to review full report at Codecov.
|
johnomotani
reviewed
Dec 12, 2019
xbout/boutdataset.py
Outdated
| @@ -209,10 +212,12 @@ def animate_list(self, variables, animate_over='t', save_as=None, show=False, fp | |||
| """ | |||
|
|
|||
| nvars = len(variables) | |||
| std_format = False | |||
There was a problem hiding this comment.
I think it makes sense to remove the blank figures even when nrows and/or ncols are given - I think it's unlikely that the blank axes are useful. So we can remove the std_format condition.
Even if 'nrows' and/or 'ncols' was given explicitly, it makes sense to delete any blank axes with no plot, so remove the std_format flag.
johnomotani
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will likely change this in the future. But for now this will remove blank subplots from figure.