Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Risky tests #160

Closed
eigan opened this issue Oct 24, 2017 · 1 comment
Closed

Risky tests #160

eigan opened this issue Oct 24, 2017 · 1 comment

Comments

@eigan
Copy link

eigan commented Oct 24, 2017 •
edited
Loading

PHPUnit is reporting that there are 208 risky tests at the moment. This is because these tests are not using the PHPUnit methods for assertions.

Would you be interested in a pull request for converting from your bovigo\assert to PHPUnit methods?

EDIT: This is not reported on Travis for some reason. hm
@mikey179
Copy link
Member

As I converted them recently from PHPUnit to bovigo/assert I don't want to convert them back. ;)

However, over at https://github.com/mikey179/bovigo-assert I'd be interested in why you are getting 208 risky tests when I and Travis CI don't...

@eigan eigan mentioned this issue Oct 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eigan @mikey179