Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL certificate for bower.io & subdomains #45

Closed
rayshan opened this issue Jun 29, 2014 · 5 comments
Closed

SSL certificate for bower.io & subdomains #45

rayshan opened this issue Jun 29, 2014 · 5 comments

Comments

@rayshan
Copy link
Member

rayshan commented Jun 29, 2014

Would like to see the team's appetite to make things a little more secure. We can get a free cert from StartSSL, however it only allows 1 subdomain. We may need at least:

Also maybe this can be used for the CLI tool as well?

https-all-the-things-300x225

@rayshan
Copy link
Member Author

rayshan commented Jun 29, 2014

Just realized that Github Pages doesn't support SSL on custom domains. This may have to wait...

isaacs/github#156

@rayshan
Copy link
Member Author

rayshan commented Jul 17, 2014

Heads up @desandro - Chrome 36 is throwing an error b/c of using twitter's https API:

Uncaught SecurityError: Failed to read the 'contentDocument' property from 'HTMLIFrameElement': Blocked a frame with origin "http://bower.io" from accessing a frame with origin "https://platform.twitter.com".  The frame requesting access has a protocol of "http", the frame being accessed has a protocol of "https". Protocols must match.

Embed still shows up though so maybe more of a warning.

@desandro
Copy link
Member

Interesting. I'm not seeing that error on my side. The script that's added is

<script id="twitter-wjs" src="http://platform.twitter.com/widgets.js"></script>

But I see that images within the iframe are https.

@rayshan
Copy link
Member Author

rayshan commented Jul 17, 2014

False alarm, caused by chrome extensions on my end, sorry!

qgustavor added a commit to qgustavor/asvd.github.io that referenced this issue Sep 20, 2015
Those two links couldn't be updated:

* bower.io (issue reported bower/bower.github.io#45)
* visibleearth.nasa.gov/view.php?id=73934 (not sure how to report it, as it's a gov website)

If there are HTTPS equivalent versions for those URLS prefer those.
@cedced19
Copy link
Member

If Github Pages doesn't support SSL, why this isssue is still open?

@faceleg faceleg closed this as completed Nov 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants
@desandro @faceleg @rayshan @cedced19 and others