Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added type definition for isBrowser in Parser Class #390

Merged
merged 1 commit into from
Jan 28, 2020
Merged

added type definition for isBrowser in Parser Class #390

merged 1 commit into from
Jan 28, 2020

Conversation

ashernguyen
Copy link
Contributor

There is no definition for isBrowser method within Parser class.

Property 'isBrowser' does not exist on type 'Parser'

This PR is for fixing this issue.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 824

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.486%
Totals Coverage Status
Change from base Build 816: 0.0%
Covered Lines: 568
Relevant Lines: 581
💛 - Coveralls

lancedikson
lancedikson approved these changes Jan 28, 2020
View reviewed changes
Copy link
Collaborator

@lancedikson lancedikson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @ashernguyen! Thanks for contributing! Looks good, will merge and release it today!

@lancedikson lancedikson merged commit 07fcffe into bowser-js:master Jan 28, 2020
@lancedikson
Copy link
Collaborator

Has been released as 2.9.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lancedikson lancedikson lancedikson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashernguyen @coveralls @lancedikson