-
Notifications
You must be signed in to change notification settings - Fork 80
Adds release date replacement (closes #103) #115
Conversation
@kherge any feedback on this? Thanks! |
At the moment, the configuration setting can be accepted by Box but it will not actually do anything. There is a function called getProcessedReplacements() that gathers all of the special placeholder names for actual processing. If you added it after line 828 and update the replacement test I can merge the PR. |
Sure, I'll try to update the PR asap. Are you happy using |
I think you mean the name of the configuration setting? I'm okay with that. |
@kherge done, let me know if is ok now |
This looks good and I'm ready to merge it, but I just had an idea. Would it be useful to be able to specify the date format instead of hardcoding it? |
Makes sense to me though the actual format is quite generic and I guess it will be fine for a lot of users. I can add it to this PR is you like |
If you don't mind doing so I would really appreciate it! |
@kherge done |
Adds release date replacement (closes #103)
I forgot to mention that the JSON validation schema needs to be updated, but I took care of that. Thanks for your help! Version 2.6.0 is now live. |
Glad to be useful, thank you for your time :-) |
As mentioned in #103 it would be nice to specify a release date a la composer. The placeholder name is
datetime
but maybereleasedate
could be more meaningful.As of now the output is a string like
2015-10-28 10:34:23