Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(viewer): Media can muted autoplay if failed at first #1054

Merged
merged 2 commits into from
Aug 16, 2019
Merged

fix(viewer): Media can muted autoplay if failed at first #1054

merged 2 commits into from
Aug 16, 2019

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented Aug 16, 2019

No description provided.

@mxiao6 mxiao6 requested review from jstoffan and mickr August 16, 2019 17:44
@mxiao6 mxiao6 requested a review from a team as a code owner August 16, 2019 17:44
@boxcla
Copy link

boxcla commented Aug 16, 2019

Verified that @mxiao6 has signed the CLA. Thanks for the pull request!

jstoffan
jstoffan approved these changes Aug 16, 2019
View reviewed changes
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's use a commit message like fix(video): Video player now attempts muted autoplay if blocked

@mergify mergify bot merged commit f55857e into box:master Aug 16, 2019
@mxiao6 mxiao6 deleted the 4614-autoplay branch August 16, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickr mickr mickr approved these changes

@jstoffan jstoffan jstoffan approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mxiao6 @boxcla @jstoffan @mickr