Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Validating annotation thread params #17

Merged
merged 8 commits into from
Apr 5, 2017
Merged

Fix: Validating annotation thread params #17

merged 8 commits into from
Apr 5, 2017

Commits on Apr 4, 2017

  1. Validating if document and image annotations contain proper location … 

    …information
    @pramodsum
    pramodsum committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    04e26b9 View commit details
    Browse the repository at this point in the history

  2. Fix unit tests

    @pramodsum
    pramodsum committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    ffc4500 View commit details
    Browse the repository at this point in the history

  3. Updating Annotator unit tests to match new standard

    @pramodsum
    pramodsum committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    af2c9cf View commit details
    Browse the repository at this point in the history

  4. Ensure blank notifications are never created for 'annotationerror' ev… 

    …ents
    @pramodsum
    pramodsum committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    d92934b View commit details
    Browse the repository at this point in the history

  5. Fixes from comments 

    - Also includes fix for thread locale to be correctly set for image
  point annotations
- Prevents multiple validation notifications from being triggered while
  another validation notification is already being displayed
    @pramodsum
    pramodsum committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    c1747e7 View commit details
    Browse the repository at this point in the history

  6. Removing redundant checks

    @pramodsum
    pramodsum committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    a47fde6 View commit details
    Browse the repository at this point in the history

  7. Removing checkValidThread() and emission of 'annotationerror' message… 

    … in Annotator

- Returns null when validateThreadParams() fails
    @pramodsum
    pramodsum committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    d7f3181 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into annotations

    @pramodsum
    pramodsum authored Apr 4, 2017
    Configuration menu
    Copy the full SHA
    78bd4ea View commit details
    Browse the repository at this point in the history