Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Create annotation in API using thread rather than threadNumber #315

Merged
merged 2 commits into from Aug 17, 2017
Merged

Fix: Create annotation in API using thread rather than threadNumber #315

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ba5e5f
Fix: Create annotation in API using thread rather than threadNumber
pramodsum Aug 17, 2017
0431093
Merge branch 'master' into refactor_annotations
pramodsum Aug 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/lib/annotations/AnnotationService.js
View file
Open in desktop
Expand Up @@ -86,8 +86,12 @@ class AnnotationService extends EventEmitter {
threadID: annotation.threadID
},
message: annotation.text,
threadNumber: annotation.threadNumber
thread: annotation.threadNumber
})
// NOTE: Ensure that threadNumbers are sent to the API as
// thread, else the API created annotation will have an
// incremented threadNumber. This is due to the naming system
// in the annotations API
})
.then((response) => response.json())
.then((data) => {
Expand Down