Fix: Check correct options when passing in BoxAnnotations instance #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @pramodsum has signed the CLA. Thanks for the pull request! |
pramodsum
force-pushed
the
annotations
branch
from
31216e7
to
acadd3d
Compare
src/lib/Fullscreen.js
Outdated
| document.addEventListener('webkitfullscreenchange', this.fullscreenchangeHandler); | ||
| document.addEventListener('mozfullscreenchange', this.fullscreenchangeHandler); | ||
| document.addEventListener('MSFullscreenChange', this.fullscreenchangeHandler); | ||
| document.addEventListener('fullscreenchange', this.fullscreenchangeHandler); |
There was a problem hiding this comment.
What're the reasons for removing these event listeners?
There was a problem hiding this comment.
We were playing around with those on Friday. @DanDeMicco has a PR addressing this soon :)
There was a problem hiding this comment.
Whoops I might have forgotten to properly rebase with this. It's unrelated to my commit. Fixing that now
pramodsum
force-pushed
the
annotations
branch
from
acadd3d
to
dcae592
Compare
JustinHoldstock
approved these changes
Jan 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.