Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support stream upload of new file versions #766

Merged
merged 5 commits into from
Apr 1, 2021
Merged

Support stream upload of new file versions #766

merged 5 commits into from
Apr 1, 2021

Conversation

swfree
Copy link
Contributor

@swfree swfree commented Mar 30, 2021

Goals ⚽

  • Add support for stream upload of new file versions. Stream upload of new files already exists.

Testing Details 🔍

  • Added unit tests

jlawton
jlawton previously approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@jlawton jlawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'd love to see us also support the if-match and the very badly named content-md5 headers. Particularly the former I think is important for correctness of some applications.

@swfree
Copy link
Contributor Author

swfree commented Mar 31, 2021

Thanks @jlawton! I added support for If-Match to both streamUploadVersion & uploadVersion. I'll file a ticket separately for adding content-md5 headers throughout since that'll include some extra changes to support it

jlawton
jlawton previously approved these changes Mar 31, 2021
View reviewed changes
Sources/Modules/FilesModule.swift Outdated Show resolved Hide resolved
@swfree @jlawton
Update Sources/Modules/FilesModule.swift
10819f3 
Co-authored-by: James Lawton <jlawton@box.com>
@swfree swfree merged commit b3c3c8b into master Apr 1, 2021
@swfree swfree deleted the stream-upload-version branch April 1, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlawton jlawton jlawton approved these changes

@sujaygarlanka sujaygarlanka sujaygarlanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swfree @jlawton @sujaygarlanka