Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Improve file download example to close file after download is complete #793

Merged
merged 2 commits into from
Jan 25, 2023
Merged

docs: Improve file download example to close file after download is complete #793

merged 2 commits into from
Jan 25, 2023

Conversation

superojla
Copy link
Collaborator

Small change to automatically close the downloaded file.

Fixes DDOC-754

@coveralls
Copy link

coveralls commented Jan 25, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4006705353

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.481%
Totals Coverage Status
Change from base Build 3937146774: 0.0%
Covered Lines: 3413
Relevant Lines: 3651
💛 - Coveralls

@lukaszsocha2 lukaszsocha2 changed the title File download code change docs: Improve file download example to close file afterwards Jan 25, 2023
@lukaszsocha2 lukaszsocha2 changed the title docs: Improve file download example to close file afterwards docs: Improve file download example to close file after download is complete Jan 25, 2023
@lukaszsocha2 lukaszsocha2 merged commit c0b2cd4 into main Jan 25, 2023
@lukaszsocha2 lukaszsocha2 deleted the DDOC-754-file-download-autoclose branch January 25, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszsocha2 lukaszsocha2 lukaszsocha2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@superojla @coveralls @lukaszsocha2