Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug: running with nose multiprocess raised error #77

Merged
merged 1 commit into from
Dec 9, 2015
Merged

fixed bug: running with nose multiprocess raised error #77

merged 1 commit into from
Dec 9, 2015

Conversation

danielwuz
Copy link
Contributor

Fixed a bug: running with --processes gives error:

20:51:00     is_multiprocess = getattr(options, 'multiprocess_workers', 0) > 0
20:51:00 TypeError: unorderable types: str() > int()

@boxcla
Copy link

boxcla commented Dec 7, 2015

Hi @danielwuz, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla

Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

@danielwuz
Copy link
Contributor Author

I'm checking the failing tests, should've run the tests before opening a PR.

@danielwuz
Copy link
Contributor Author

CLA signed

@boxcla
Copy link

boxcla commented Dec 7, 2015

Verified that @danielwuz has just signed the CLA. Thanks, and we look forward to your contribution.

@danielwuz
Copy link
Contributor Author

I have hard time figuring out the pylint issue, it gives error unrelated to my change, therefore I'm closing this PR and open an issue instead. The cause and fix should be straightforward according to the error message.

@danielwuz danielwuz closed this Dec 7, 2015
@Jeff-Meadows Jeff-Meadows reopened this Dec 9, 2015
@Jeff-Meadows
Copy link
Contributor

Thanks for the PR.

Hey the pylint issues you were having are due to a new version of pylint.

I've pushed a PR to address them. If you rebase off of master, the tests should pass and I can merge this one.

@danielwuz
Copy link
Contributor Author

Done =)

Jeff-Meadows added a commit that referenced this pull request Dec 9, 2015
fixed bug: running with nose multiprocess raised error
@Jeff-Meadows Jeff-Meadows merged commit e887db6 into box:master Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants