This repository has been archived by the owner on May 26, 2022. It is now read-only.
Separated getCellValue into multiple functions #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @Lewiscowles1986 has signed the CLA. Thanks for the pull request! |
|
TODO: Make changes, then revisit and destroy readability with PSR 👎 😢 |
Author: Lewis Cowles <lewiscowles@me.com> Committer: Lewis <lewis@chromebook> modified: src/Spout/Reader/XLSX.php
|
Right Unit Tests Expanded along with sample files to include "str" string and invalid date (although not ideal, it is nice to be able to read invalid dates as null) |
|
as a fringe benefit, coverage for this file up from 93.52 to 100% 😄 |
|
Fantastic! Thanks 😃 |
adrilo
added a commit
that referenced
this pull request
Jul 6, 2015
Separated getCellValue into multiple functions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the larger getCellValue into a smaller function with utility functions