This repository has been archived by the owner on May 26, 2022. It is now read-only.
XLSX Date Writer #816
Closed
XLSX Date Writer #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This methods was untested, so this adds basic support for all data types currently tested by other test cases in this class.
Adds support for DateTimeImmutable by using the shared DateTimeInterface which both this and DateTime implement.
This adds support for writing DateTime and DateTimeImmutable values with the XLSX writer. The dates are written using the date type (t="d") which must then specify an ISO date as the value (as opposed to a linear date in previous versions).
|
Hi @rodnaph, While your solution is technically true, I did a quick test this in different softwares and none of them supported this format:
This is unfortunately a deal breaker... |
|
I tested Numbers on Mac 6.2 and it does support this format, I'm surprised Google Sheets doesn't though... I'll investigate and re-open this if I can find a way around it. |
|
Would you accept a PR that omitted the |
|
Using a timestamp would be the best approach indeed. But it requires setting a cell style (there are some built-in styles for dates that can be used). This also poses some questions:
|
|
Solved in openspout/openspout#13 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for writing instances of
DateTimeInterface(ie.DateTimeandDateTimeImmutable) with the XLSX writer.Previous issues such as #781 and #797 have been closed with regards this issue, but I believe #781 is actually valid. From my research (disclaimer: I'm new to this XML format...) it seems the numeric date format for "serial dates" referenced in the closing comment of #781 are those originally supported by openxml, for example...
However, ISO/IEC 29500-1:2016 adds support for ISO dates using the type
d.https://www.iso.org/standard/71691.html
Thoughts? If this is valid I'm happy to re-work this PR as needed, cheers.