Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Box.Application.hasModule function. #153

Closed
wants to merge 1 commit into from
Closed

Add Box.Application.hasModule function. #153

wants to merge 1 commit into from

Conversation

PKuebler
Copy link

@PKuebler PKuebler commented Mar 1, 2016

return if object added

@boxcla
Copy link

boxcla commented Mar 1, 2016

Hi @PKuebler, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla

Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

@j3tan
Copy link
Contributor

j3tan commented Mar 1, 2016

Hi @PKuebler,

What's the background on this change? Can you file an issue ticket to discuss?

@PKuebler
Copy link
Author

PKuebler commented Mar 1, 2016

hi,

I have a module written that modules placed on the page. Not all elements have a t3js module, so I want to check it before it executes Box.Application.start().

@j3tan
Copy link
Contributor

j3tan commented Mar 1, 2016

Is this so you can dynamically load the module if it doesn't exist yet?

You can always call Box.Application.startAll() instead of start() which should basically handle your case. In addition, I highly recommend calling Box.Application.stopAll() on the element before you replace it.

@j3tan j3tan closed this Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants