-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all the templates so that the vm_name and suffix are defined in user variables #217
Conversation
…s to the template name.
…e user variables in all of the templates so that they're grouped together.
…o use the vm_name and vm_suffix user variables.
…in.json templates into the vm_suffix user variable.
All of the templates seem to validate w/o issue, just need to do a few test builds to 100% confirm the paths are the same. |
Seems to work. Original template name was defined as the following which should emit the box under
Here's an example of the emitted box when using a template that specifies an empty vm_suffix.
Here's an example of the emitted box when using a template that specifies a default vm_suffix (
And here's an example of the emitted box with an explicitly specified vm_suffix (
|
...and to demonstrate fully controlling the name (after rm'ing the boxes made by the prior tests):
|
Update all the templates so that the vm_name and suffix are defined in user variables that can be controlled by the user. This closes issue boxcutter#216.
This PR simply replaces all of the
vm_name
keys defined in the builders with a user-variablevm_name
. This makes it easier to change the "vm_name" by only needing to update it in one place.The suffix for the
*-cygwin.json
and*-ssh.json
templates was also made into a user variable (vm_suffix
) in case the full name is desired to be controlled. As another benefit, this gives the user the ability to fully control the name of the box that is emitted.The
vagrantfile_template
and any files that re-use the template name are not included as these are specific to the the template and so were considered part of the actual template. The output name in the post-processors is now 100% controlled by the user variables (excluding the hyphens).