Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications bumb direct messages channel up #127

Closed
boxdot opened this issue Jan 28, 2022 · 3 comments · Fixed by #134
Closed

Notifications bumb direct messages channel up #127

boxdot opened this issue Jan 28, 2022 · 3 comments · Fixed by #134

Comments

@boxdot
Copy link
Owner

boxdot commented Jan 28, 2022

Looks like reading notification push the direct message channels up even there is no message there.
@boxdot boxdot changed the title Notifications bumb direct channel up Notifications bumb direct messages channel up Jan 28, 2022
@cxloe
Copy link

cxloe commented Feb 9, 2022

this is especially bad with large groups. seems like all the delivery notifications pop up in the sidebar when sending messages

@Sup3Legacy
Copy link
Contributor

What do you mean precisely? I failed to reproduce the issue as I understand it.

@boxdot
Copy link
Owner Author

boxdot commented Feb 10, 2022

When a person writes in a group, there are incoming notification messages from this person and those bubble up the channel with this person.

I have a fix for that. Will upload soon.

boxdot added a commit that referenced this issue Feb 10, 2022
@boxdot
Fix: Notifications bumb direct messages channel up
4eea8a9 
Sometimes we get an incoming message which is empty (delivery notification?). Such messages did bumped their channel up.

Also notify about attachments now.

Fixes #127
@boxdot boxdot mentioned this issue Feb 10, 2022
Merged
boxdot added a commit that referenced this issue Feb 10, 2022
@boxdot
Fix: Notifications bumb direct messages channel up (#134)
f89dbf6 
Sometimes we get an incoming message which is empty (delivery notification?). Such messages did bumped their channel up.

Also notify about attachments now.

Fixes #127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Notifications bumb direct messages channel up boxdot/gurk-rs
3 participants
@boxdot @Sup3Legacy @cxloe