Fix issue with TypeError for empty file diffs
#271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Here's the fix for the problem I stumbled upon when I was doing some experiments on running mutation tests based on git patch. The problem was
whatthepatchlibrary returnsNoneinstead of empty list as a value fordiff.changesif file has no changes (new empty file, renamed empty file, removed empty file - tested on MacOS and Windows 10), which made mutmut to crash because of the set comprehension requirement in__init__.py. I tested it on current version of whatthepatch (1.0.3) and one from requirements (0.0.6), but for both versions the behaviour was the same.Unfortunately, not only it didn't parse the patch, but also crash
mutmut. Therefore, I thought it would be good idea to fix it, since without it it would require for my use case to generate list of changed lines externally as a coverage report and pass it with the--use-coverageparameter.As before, I added a regression unit test suite to make sure it won't happen again.