Update tqdm.py #44
Update tqdm.py #44
Conversation
add possibility to cumulate or not progress to the parent task progress if parent_task_id is provided
Clarify reporting with sub-tasks and document new option linked to fix#43
|
Thanks for contribution... But why do we need So i assume this is double code for the same, isn't it? Expand the README is fine... On the other hand, this has a general problem: it is not guaranteed that the code works, because it is untested. Actually, it is better to add example code and refer to it. Because they can be added to the tests. Maybe we should enhance https://github.com/boxine/django-huey-monitor/blob/master/huey_monitor_tests/test_app/tasks.py and add more DocStrings there and make more links from README to it? |
|
I implemented it this way with For me, from a conceptual point of view, we should have In my different types of application, the progress counters of the main task correspond to the number of sub-tasks to be run. But on the other side, as I told you when I opened the issue, to be useful, the Essentially because a sub-task can take 10h or 24h to complete. Last month, I had a process which was not showing any progress for 3 weeks. It made me decide to invest more effort into designing a more efficient progress monitoring of my tasks. For the testing, I never had professional training on it and I don't know how you work, so anything is fine by me, and I'll be glad to learn how you handle it and integrate your best practices into the ways I work. I'm not a professional IT. Just an advanced business user who learns by doing and solving his own business isues |
|
I implemented your comments. |
|
@formacube linting failes, see: https://github.com/boxine/django-huey-monitor/runs/4324397296?check_suite_focus=true#step:9:24 You can run tests and linting local with: Helpfull is also: |
that's a bit stupid if you ask me. but if it pleases you and finally makes this available... I've done it For such trivial stuff which are not even errors but more your own preferences, it would take much less time and effort for you to put it directly to your liking. No real added value to involve me
|
linting should be ok and in line with your personal perferences. I use double line breaks to make code reading & structure easier. That's my preference. No need to involve me in the future if you prefer lines of 119 characters or if you don't like 2 lines break in a row. |
|
Can you go on with this ? |
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 83.29% 83.46% +0.17%
==========================================
Files 35 35
Lines 778 786 +8
==========================================
+ Hits 648 656 +8
Misses 130 130
Continue to review full report at Codecov.
|
other linting changes (extra whitespace ... no comment !!!!)
|
It's green... But i think about to refactor this code part, see: #57 So this PR is useless :( |
|
I close this in favour of a complete rewrite here: #58 |
|
Implement the idea with #61 |
add possibility to cumulate or not progress to the parent task progress if parent_task_id is provided